Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.condensePath isn't used everywhere utils.which is #151

Open
ryhinchey opened this issue Feb 26, 2020 · 1 comment · May be fixed by #259
Open

utils.condensePath isn't used everywhere utils.which is #151

ryhinchey opened this issue Feb 26, 2020 · 1 comment · May be fixed by #259

Comments

@ryhinchey
Copy link
Collaborator

utils.condensePath is used for binaries and managers but not languages, databases, ides, etc.

Is there a reason for that? It seems to me that we'd want to replace process.env.HOME with ~ for every case. If so, I think it'd make sense to create a new util that does uses utils.which and utils.condensePath.

Happy to make a PR if this is something that sounds reasonable
@ryhinchey ryhinchey changed the title utils.condensePath isn't used everywhere it should be utils.condensePath isn't used everywhere utils.which is Feb 26, 2020
@tabrindle
Copy link
Owner

I think you might be right. The original intention was to obscure the user directory for paths that frequently contained them, but due to the wonderously diverse nature of environments, anything could be anywhere.

If you're willing go ahead. I'd approve this change.

kou029w added a commit to kou029w/envinfo that referenced this issue May 28, 2024
@kou029w
feat: integrated utils.condensePath into utils.which
8294536 
fixed tabrindle#151

Removed `utils.condensePath` and updated all references to use the enhanced `utils.which`, which now replaces the home directory with ~. Updated and added tests to ensure functionality.
@kou029w kou029w linked a pull request May 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: integrated utils.condensePath into utils.which kou029w/envinfo
2 participants
@tabrindle @ryhinchey