Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone-input bugs with defaultCountry option and display #13

Open
gazpachu opened this issue Aug 10, 2021 · 0 comments
Open

Phone-input bugs with defaultCountry option and display #13

gazpachu opened this issue Aug 10, 2021 · 0 comments

Comments

@gazpachu
Copy link
Contributor

The defaultCountry option is very important to correctly default to as in most of our use cases this will default to the current shop and never be changed.

if value is blank or undefined, default Country should be selected - currently is not working

If country flag was selected, then input deleted, country-flag should remain the same (this is working correctly)

Country code should not show inside the text input, only in the dropdown (most people don’t know their own country code and it can be confusing)

Joan:

Simeon CheesemanI’d remove the last requirement. I think it should be visible

Simeon:

It’s an issue of space, the input has a very tight constraint on horizontal space so in a lot of cases (like mobile) there isn’t enough space to show the country code too.

As this is a bug fix ticket not a feature change ticket the requirement should stay. If you want to go get something rolling with redesigning how the functionality of the phone input is supposed to work that’s fine - there’s other issues we’d have to address as well in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants