Skip to content
This repository has been archived by the owner on Nov 7, 2024. It is now read-only.

chore: expose SSL port in Dockerfile and enable SSL in matterbridge o… #265

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

dohun0310
Copy link
Contributor

@dohun0310 dohun0310 commented Aug 16, 2024

…ptions

Proposed Changes

Describe the changes you made.

  • Added the -ssl option to the matterbridge command.
  • Opened port 8443 for SSL connections.

Related Issues

Related issues or pull requests

#133

@t0bst4r
Copy link
Owner

t0bst4r commented Aug 16, 2024

Where does matterbridge take the certificate for https://127.0.0.1:8443 from?
Additionally i dont know what else impact it has, so I'd recommend adding a ENV as a flag and add the ssl conditionally (default false - to not break anything for others).

@dohun0310
Copy link
Contributor Author

Luligu/matterbridge#62 (comment)
Since /root/.matterbridge has already been added to the VOLUME, there’s no issue with adding certificates to /root/.matterbridge/certs.

Additionally, I don’t think it’s necessary to create an env variable for selecting SSL, as port 8443 should only be used by those who need it.

@dohun0310
Copy link
Contributor Author

However, if you, as the maintainer, prefer that I handle this, I have already completed the task. Does this meet your expectations?

@t0bst4r t0bst4r merged commit dc2b5e4 into t0bst4r:main Aug 17, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants