Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Ingress support #36

Closed
DJBenson opened this issue Oct 29, 2024 · 6 comments · Fixed by #213
Closed

[Enhancement] Ingress support #36

DJBenson opened this issue Oct 29, 2024 · 6 comments · Fixed by #213
Labels
feature Feature Request

Comments

@DJBenson
Copy link

Just throwing a suggestion out there that it would be good if the web portal was accessble using HA ingress.

@t0bst4r
Copy link
Owner

t0bst4r commented Nov 10, 2024

I like the idea of ingress, too. BUT...
This addon is using the host network mode. This means that ports which are used by this addon are blocked for the host computer, too. No other addon or integration are able to use the web-port (and the matter ports).
That's why i made the web port configurable - to not block other addons.

When using ingress, the port cannot be changed. I need to tell ingress which port is used for the web ui. When changing the port in the configuration, ingress will not be able to proxy the addon web ui.

I am not really sure, how to solve that. Either:

  1. use ingress, but remove the port configuration of the web ui
  2. don't use ingress, but keep the port configurable

@DJBenson
Copy link
Author

The official Matter add-on uses host networking AND allows the web UI port to be configured. See config here.

I'm not a developer but to me it looks like if you add the following to the config.yaml of the addon it might work;

ingress: true
ingress_port: 8482

and then to allow the port to be configured;

ports:
  8482/tcp: null

and remove the port config (which is now handled by the docker expose feature);

web_port: 8482

@DJBenson
Copy link
Author

Not quite that simple it seems as web_port is required but perhaps that's because it's designed such it doesn't currently work with ingress - the point is other addons do work with host network and port configs so hopefully something that can be implemented.

@t0bst4r
Copy link
Owner

t0bst4r commented Nov 29, 2024

closed by accident. i still need to test and configure the addon.

@t0bst4r
Copy link
Owner

t0bst4r commented Nov 30, 2024

ingress is up and running. see #230 for some expected error.

@t0bst4r t0bst4r closed this as completed Nov 30, 2024
@DJBenson
Copy link
Author

Great work. Many thanks @t0bst4r.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature Request
Projects
None yet
2 participants