Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with html-webpack-plugin v4 #25

Closed
kroko opened this issue Apr 1, 2020 · 3 comments
Closed

Compatibility with html-webpack-plugin v4 #25

kroko opened this issue Apr 1, 2020 · 3 comments

Comments

@kroko
Copy link

kroko commented Apr 1, 2020

Does not work with html-webpack-plugin 4.x. Still works with 3.2.0.

Reason probably being jantimon/html-webpack-plugin#1369

(node:11842) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'tapAsync' of undefined
    at /Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/inline-manifest-webpack-plugin/index.js:18:18
    at SyncHook.eval [as call] (eval at create (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:11:1)
    at Compiler.newCompilation (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:631:26)
    at /Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:667:29
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
    at Compiler.compile (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:662:28)
    at /Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:321:11
    at Compiler.readRecords (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:529:11)
    at /Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/webpack/lib/Compiler.js:318:10
    at eval (eval at create (/Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:11:1)
    at /Users/reinis/Documents/warpcloud/WARP/CODE-WEB-LIVE/valet/jcdecaux-t001-01-02-kiosk/node_modules/stylelint-webpack-plugin/dist/linter.js:48:5
(node:11842) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:11842) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@jantimon
Copy link

jantimon commented Apr 1, 2020

The reason here is a different one - tapAsync is no longer the recommended plugin interface by the webpack core team. Therefore the html-webpack-plugin changed to the new format:

https://github.com/jantimon/html-webpack-plugin#events

@szrenwei
Copy link
Owner

szrenwei commented Jun 4, 2020

@szrenwei szrenwei closed this as completed Jun 4, 2020
@shridevishetty18
Copy link

Please use react-dev-utils instead ( https://github.com/facebook/create-react-app/tree/master/packages/react-dev-utils#new-inlinechunkhtmlpluginhtmlwebpackplugin-htmlwebpackplugin-tests-regex ), it does the same thing.

inline-manifest-webpack-plugin is not supported with webpack5. Are there any alternatives for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants