-
Notifications
You must be signed in to change notification settings - Fork 122
TypeScript Module Naming #181
Comments
@guybedford I'll check if this change can fit into the forthcoming TypeScript release. In case if it cannot - is this issue a release blocker or ES6 module loader/SystemJS can be released without this part and I can submit it later as a PR? |
@vladima thanks. Yes we can patch later certainly - it does block the full use case but will just note that bundles are not supported for TypeScript yet in the release notes. |
@guybedford as I see SystemJS 0.17 was already released. Assuming that we can fix this issue on the TypeScript side pretty soon, what is the timeline for the next patch that can actually use this fix? |
@vladima we can roll out the patches quickly now that the release is out, so in just a day or two now. |
@guybedford a general question: how SystemJS / Builder expect transpile errors to be reported?
I would like to to apply the same error reporting policy to TypeScript scenarios to be consistent with other transpilers |
The story here isn't excessively developed - we're just throwing the error from the compiler through the promise chain in a way that looks good in the browser and Node. Whatever works best within a single error object for TypeScript is great. We just had to alter this for Traceur because the error array didn't display well when thrown. There is the ability to do this differently between the browser and Node, although in future we plan on converging into a single transpiler implementation. |
Released in 0.12.0. Tests tracking at #200. |
//cc @vladima
In order to support bundling with TypeScript, we need to tell typescript what to name the compiled ES6 modules.
For example, in Traceur we pass
load.name
as a parameter to the transform - https://github.com/systemjs/builder/blob/master/compilers/esm.js#L80.This then provides the output -
System.register("load name", ...
where"load name"
is the name we set.This is the last critical issue to get full TypeScript support. #178 and #177 will then help to improve the experience too.
The text was updated successfully, but these errors were encountered: