Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pop-keyboard-shortcuts.md #1236

Closed
wants to merge 1 commit into from
Closed

Update pop-keyboard-shortcuts.md #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions content/pop-keyboard-shortcuts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,13 @@ Directional actions can use either the standard arrow keys or their Vim equivale
| ------------------------------------------------------------------------------------------ | ---------------------------------------------- |
| <kbd>SUPER</kbd> + <kbd>Ctrl</kbd> + <kbd>↑</kbd>/<kbd>↓</kbd> | Navigate between workspaces |
| <kbd>SUPER</kbd> + <kbd>Home</kbd>/<kbd>End</kbd> | Navigate to first/last workspace |
| <kbd>SUPER</kbd> + <kbd>Shift</kbd> + <kbd>Direction keys</kbd> | Move active window between workspaces/displays |
| <kbd>SUPER</kbd> + <kbd>Shift</kbd> + <kbd>Direction keys</kbd> | Move active window between upper and lower workspaces as well as right and left monitors respectively |
| <kbd>SUPER</kbd> + <kbd>Shift</kbd> + <kbd>Ctrl</kbd> + <kbd>↑</kbd>/<kbd>↓</kbd> | Move the active window between upper and lower displays
| <kbd>SUPER</kbd> + <kbd>ESC</kbd> | Lock the screen |

### Use the launcher

The launcher allows searching through open windows and installed applications, and also has the additional functions listed below.
The launcher allows searching through open windows and installed applications and has the additional functions listed below.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the drive for conciseness, this change makes the "and"s run together and makes the sentence less clear. I think the old wording for this line was better.

If you want to make it more grammatically correct than it was originally, just add "it" after the "and" (following the comma) since this is an independent clause and should have a subject. (So it should read "and it also has..." after the comma.) Or simply separate it out into two sentences to get rid of the second "and" here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it myself since it's been a while and the PR author doesn't seem to be around at the moment.


| Shortcut/command | Action |
| ---------------------------------------------------------- | ------------------------------- |
Expand Down
Loading