Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use peerDependencies to avoid context provider version clash #1388

Closed
hasparus opened this issue Dec 21, 2020 · 1 comment · Fixed by #1867
Closed

use peerDependencies to avoid context provider version clash #1388

hasparus opened this issue Dec 21, 2020 · 1 comment · Fixed by #1867
Labels
bug Something isn't working released This issue/pull request has been released.

Comments

@hasparus
Copy link
Member

see #1351

I claim we can't have MDX packages nor Emotion in dependencies, and we should use peerDependencies instead.
@hasparus hasparus added the bug Something isn't working label Dec 21, 2020
@hasparus hasparus mentioned this issue Dec 21, 2020
Merged
@hasparus hasparus mentioned this issue Jul 19, 2021
Merged
4 tasks
@hasparus
Copy link
Member Author

🚀 Issue was released in v0.13.0 🚀

@hasparus hasparus added the released This issue/pull request has been released. label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Emotion and MDX packages to peerDeps system-ui/theme-ui
1 participant
@hasparus