-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for automatic JSX runtime #1237
Add support for automatic JSX runtime #1237
Conversation
…on whether sx in scope or not
This commit thread is a roller coaster of emotion (pun intended?)
Thanks for putting in the work for the rest of us @dcastil 👍 |
@arshad Haha yes, I was fighting TypeScript and as I fixed type bugs, new came up again and again. 😄 But now it works! |
I'll handle the conflicts and changelog. |
@dbertella's comment is already answered in another issue, but I'll leave this here for posterity. To use Theme UI with automatic runtime you need Theme UI version greater than 0.5.0-alpha. However, classic runtime still works, so if you're already using it you don't need to migrate, it's possible to configure this in your Babel config or by setting |
Closes #1160
React introduced the new JSX transform and Emotion added support in emotion-js/emotion#1970. So everything is in place for Theme UI to support the new JSX transform. 😊
To dos: