Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant responsive values not working alongside other responsive values #1030

Closed
julianbenegas opened this issue Jun 26, 2020 · 1 comment
Closed

Comments

@julianbenegas
Copy link
Contributor

Describe the bug
You have a component with the variant property inside sx. This variant holds a responsive value, say fontSize: ["12px", "16px"]. If you then put another responsive value to the sx, then the variant's responsive value won't work.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this sandbox
  2. Resize the window
  3. See that the text doesn't change size

Expected behaviour
The text should change it's fontSize

Additional context
It happens when using variant variant inside sx. If variant is used as a prop, it works as expected.

@julianbenegas julianbenegas changed the title Variant responsive values not working when other responsive values are present Variant responsive values not working alongside other responsive values are present Jun 27, 2020
@julianbenegas julianbenegas changed the title Variant responsive values not working alongside other responsive values are present Variant responsive values not working alongside other responsive values Jun 27, 2020
@jxnblk
Copy link
Member

jxnblk commented Jun 30, 2020

Thanks! This looks like an odd bug... possibly related to #720 and #832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants