Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ama is documented as both sensor and number entity (with weird info) #100

Open
nilrog opened this issue Apr 27, 2023 · 2 comments
Open

ama is documented as both sensor and number entity (with weird info) #100

nilrog opened this issue Apr 27, 2023 · 2 comments

Comments

@nilrog
Copy link

nilrog commented Apr 27, 2023

The key ama is listed twice in the README. Both as a sensor, and as a number entity. Probably a mistake from when it was recently exposed as a number entity. And the description in the number entity is weird as you can see here

Key Friendly name Category Enabled per default Supported Unsupported reason
ama Maximum current limit config A ✔️ ✔️
@syssi
Copy link
Owner

syssi commented Apr 27, 2023

The value is exposed as sensor entity (read-only) and number entity (read-write) at the moment. I tried to avoid a breaking change but it's probably better to remove redundancy here.

I've fixed the ama row at the docs. Are you fine with the friendly name of the entity?

@nilrog
Copy link
Author

nilrog commented Apr 27, 2023

Ok, didn't realize that it existed as a sensor before.

The ama and amp keys seems to be a bit confusing when people look for a way to limit the current. Probably because go-e doesn't really describe them so good either.
But the current friendly names does describe what they are so I don't think you need to update it.

I did notice that, after my comment yesterday on the pull-request that included changes to the PV surplus description, that the amp key is no longer described there (it used to describe using ama).
I think it should still be described there even though we now have the ids. Because ids is not a replacement for what existed before. It is a complementary feature that works together with other features in the charger.
You can use amp to limit the amount of current that the charger can use while still only using PV surplus. As an example, if energy price is high, so it makes sense to export energy, but you still want to charge the car without paying for energy, you could set ampto 8, which means that the charger will never use more than 8A, but it will still use less if there is not enough PV surplus to reach 8A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants