host-resolve: invalidate ivykis "now" after blocking calls to DNS #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging cff516a982d7e50bdf269aed27bcfeda441437b0 into 09823d1 - view on LGTM.com new alerts:
|
|
Build SUCCESS |
Signed-off-by: Balazs Scheidler <[email protected]>
MrAnno
force-pushed
the
invalidate-now-after-dns-calls
branch
from
cff516a to
ee08768
Compare
MrAnno
approved these changes
Jan 7, 2021
| @@ -362,6 +362,7 @@ afinet_dd_setup_addresses(AFSocketDestDriver *s) | |||
| if (!_setup_dest_addr(self)) | |||
| return FALSE; | |||
|
|
|||
| iv_invalidate_now(); | |||
There was a problem hiding this comment.
I think this is not necessary, as _setup_dest_addr() invalidates now through resolve_hostname_to_sockaddr().
|
Build SUCCESS |
|
My comment is not really important, the extra I'll send a newsfile entry. |
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Jan 8, 2021
Signed-off-by: László Várady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balazs Scheidler [email protected]