Improve func-test #3236
Merged
Improve func-test #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
szemere
commented
Apr 14, 2020
szemere
commented
- While investigating func-test errors - It was easier for me to see the list of failed test cases after each run.
- Checking logstore_reader was a dead code, since we returned from the loop on first iteration.
|
Build SUCCESS |
MrAnno
reviewed
Apr 16, 2020
szemere
force-pushed
the
improve_func_test
branch
from
efc7631 to
08eeca0
Compare
|
Build SUCCESS |
szemere
force-pushed
the
improve_func_test
branch
from
08eeca0 to
f3f6c59
Compare
|
Build SUCCESS |
MrAnno
previously approved these changes
Jun 16, 2020
alltilla
reviewed
Jun 19, 2020
szemere
force-pushed
the
improve_func_test
branch
from
f3f6c59 to
8624b97
Compare
|
Build SUCCESS |
MrAnno
previously approved these changes
Jun 24, 2020
gaborznagy
suggested changes
Jul 2, 2020
Signed-off-by: Laszlo Szemere <[email protected]>
Regardless of the value of logstore_store_supported, logstore_reader was never tested. We exited from the loop with the first value of the iterator, which was file reader. Signed-off-by: Laszlo Szemere <[email protected]>
Signed-off-by: Laszlo Szemere <[email protected]>
szemere
force-pushed
the
improve_func_test
branch
from
8624b97 to
07f0a7b
Compare
|
Build SUCCESS |
MrAnno
approved these changes
Jul 12, 2020
gaborznagy
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.