Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose HetznerBareMetalHosts with RootDeviceHints set over those ones without #1173

Closed
janiskemper opened this issue Feb 20, 2024 · 0 comments · Fixed by #1197
Closed

Choose HetznerBareMetalHosts with RootDeviceHints set over those ones without #1173

janiskemper opened this issue Feb 20, 2024 · 0 comments · Fixed by #1197
Labels
good first issue Good for newcomers

Comments

@janiskemper
Copy link
Contributor

/kind feature

Describe the solution you'd like
Currently, we choose the first HetznerBareMetalHost of the list that fits the criteria. This leads to the fact that a host might be chosen that does not have rootDeviceHints set. This is not a problem per se, as the user will get the necessary information printed in the status of HetznerBareMetalHost and can use it to specify the rootDeviceHints.

However, this is not optimal in the case where other HetznerBareMetalHosts are available that have the rootDeviceHints specified. The provisioning of those hosts is naturally faster than if the user has to do some manual work.

Therefore, I propose to choose those HetznerBareMetalHosts first that have the rootDeviceHints specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
1 participant