Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(event-hub): add aad diagnostic settings (SSPROD-38091) #31

Merged
merged 10 commits into from
Apr 12, 2024
Merged

feat(event-hub): add aad diagnostic settings (SSPROD-38091) #31

merged 10 commits into from
Apr 12, 2024

Conversation

matteopasa
Copy link
Contributor

Create AAD(Entra) diagnostic settings to ingest in the event hub also Entra logs

@matteopasa matteopasa requested a review from a team as a code owner March 5, 2024 13:43
ravinadhruve10
ravinadhruve10 reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before releasing, can we also please ensure to update the documentation in this module? Thanks.

modules/services/event-hub-data-source/variables.tf Show resolved Hide resolved
@matteopasa matteopasa merged commit f305bfe into main Apr 12, 2024
@matteopasa matteopasa deleted the pasa/eh/add-entra branch April 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteopasa @ravinadhruve10