Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(s3): add support for Govcloud account/org for fedramp #24

Merged
merged 5 commits into from
Nov 12, 2024
Merged

enhance(s3): add support for Govcloud account/org for fedramp #24

merged 5 commits into from
Nov 12, 2024

Conversation

jose-pablo-camacho
Copy link
Contributor

xref: https://sysdig.atlassian.net/browse/SSPROD-48794

This PR adds S3 support for GovCloud accounts and org.

@jose-pablo-camacho jose-pablo-camacho requested review from a team as code owners October 30, 2024 19:07
ravinadhruve10
ravinadhruve10 reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update the module's versions.tf with the latest provider version. Else the data source calls would fail if this is run on < 1.39 provider.

ravinadhruve10
ravinadhruve10 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jose-pablo-camacho jose-pablo-camacho merged commit 81addc2 into main Nov 12, 2024
@jose-pablo-camacho jose-pablo-camacho deleted the enhance/s3/add-gov-support branch November 12, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

@haresh-suresh haresh-suresh haresh-suresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jose-pablo-camacho @haresh-suresh @ravinadhruve10