Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two items paired as parent items in seperate locations does not show up in locations menu at all #254

Open
6 tasks done
shielnic opened this issue Sep 25, 2024 · 10 comments
Labels
🕷️ bug Something isn't working ❓ question Further information is requested

Comments

@shielnic
Copy link

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • I can replicate the issue inside the Demo install.

Homebox Version

v0.14.2

What is the issue you are experiencing?

When creating an item in one location and then creating another item in a different location and pairing them together as "Parent Item" they then do not show up under the Locations menu drop down tree and can only be found by actually selecting the location that said item is in.

How can the maintainer reproduce the issue?

Create two items like "test item pair 1" and "test item pair 2" and set one item to a location and the other one to another location then edit the items to have them assigned a parent item and select the other pair item ex: test item pair 1 will have a parent item of test item pair 2 and vise versa. Then when checking the location menu none of the drop down arrows appear for that location saying that they have the items that you sent them to.

Deployment

Docker (Linux)

OS Architechture

x86_64 (AMD, Intel)

Deployment Details

No response

@shielnic shielnic added the 🕷️ bug Something isn't working label Sep 25, 2024
@katosdev
Copy link
Contributor

I am not able to replicate this at all.

On the Demo I created 2 items:

  1. Potato
  2. Smart Rocker Light Dimmer

On the potato, the location was set to Kitchen and was provided the parent item of Smart Rocker Light Dimmer. For the Dimmer, this was given the location of Living Room

When I navigate to the locations of each, they both show up absolutely fine.
Please can you elaborate on what issue you are having? :)

@katosdev katosdev added the ❓ question Further information is requested label Sep 30, 2024
@tankerkiller125
Copy link
Contributor

Adding on to @katosdev testing, I've also tested (although in nightly), and I get the following result:
image

It's there, it's not missing entirely, but also the sub-item is not in the Office which is it's actual assigned location. However, for a tree view, I think that this is the correct way to display it.

@shielnic
Copy link
Author

shielnic commented Sep 30, 2024

Correct it doesn't show in the Tree view but when you parent single items they show up in the tree view. but if you parent the
Potato to Smart Rocker Light Dimmer and then take Smart Rocker Light Dimmer and parent to Potato you will see it disappear from the tree view.

@katosdev
Copy link
Contributor

Correct it doesn't show in the Tree view but when you parent single items they show up in the tree view. but if you parent the Potato to Smart Rocker Light Dimmer and then take Smart Rocker Light Dimmer and parent to Potato you will see it disappear from the tree view.

Hey, thanks for the clarification.
In your example this would create a loop as the item already has a parent. I’m not sure why you’re trying to parent the item in reverse?

Admittedly, there should be a validator message that the item is already a child of a parent, so I will leave the issue open as this likely needs the validation extending.

@shielnic
Copy link
Author

shielnic commented Sep 30, 2024

In my Homebox setup I have 2 coax over Ethernet devices that when I bought them they are paired together so I have one in one office and another in another office. When I moved that other one to another office I had to create a whole another asset to document where it was going so that is why I had them joined together as parent items thus making that loop.

I think in the end I was hoping to just be able to go the tree view and quickly see everything in its correct location.

@Andersama
Copy link

There is something bizarre happening when trying to nest locations at least two down. I'm not able to do it at all at least from the obvious form.

I was going to make a suggestion/feature to create multidimensional or multitree locations quickly. IE: provide a form option to do something like:

Garage Cabinet 1/Shelf 1
Garage Cabinet 1/Shelf 2 and so on...

Probably easiest to do a form that can iterate over common patterns (numbers / letters / number letter combinations)? Probably easiest to create a new location database struct which deals with this or modifying the existing one.

@tankerkiller125
Copy link
Contributor

@Andersama the existing Locations struct will actually be eliminated as part of the v1 Roadmap, and locations will actually be merged with the items table. Which will give locations all of the features that items currently have.

@Andersama
Copy link

@tankerkiller125 well since I'm new to this project, I'm not familiar with what those are. I'm more pointing out how slow it is to create locations / items in bulk. I can imagine easily adding 100's of locations and the interface at the moment would have me do that one at a time. Really if anything if you could point me to where stuff like <FormTextArea /> is defined I could probably manage creating the ui myself.

@tankerkiller125
Copy link
Contributor

For creating Items (and the associated locations) in bulk we already support CSV Imports, see https://homebox.software/en/import-csv.html For sub-locations you can do things like Kitchen / Cabinet 1 / Top Shelf and it would create the Kitchen Location, Cabinet 1 with the Kitchen as parent, and Top Shelf with Cabinet 1 as the parent of that, and the item associated with that location.

There are some limitations on it though, which the documentation points out.

Additionally, if you wanted to create items in the GUI, but not get redirected to the new location each time and move your mouse to the create button, we do support the Shift + Enter key bind to create the location, and immediately bring the location modal back up for the next location you want to add.

@Andersama
Copy link

Ah, ok, so that must be how there were example screenshots that I couldn't replicate in the gui. I saw the shortcut from the button pop-up it's still relatively slow to have to copy/paste then add some kind of identifier. I was thinking either adding a different modal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working ❓ question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants