M100(...) and status report

[smhty]

Hi Everyone,

I have a problem with the current edge version:

Description
If I change outputs via M100 command, for example M100({out1: 1}), I don't see any update in the status report.
The interesting part is that if I send M100({do1mo:1}) then I see the update in sr.
I have already included both "out1" and "do1mo" in my status report, and if I manually call {sr:n}, I can see the "out1": 1 in the report. I also make sure that "out1" is 0 before sending the M100({out1: 1}) command

Sample log
send: M100({out5:1})
receive: {'r': {}, 'f': [1, 0, 15]}
receive: {'qr': 47, 'qi': 1, 'qo': 0}
receive: {'qr': 48, 'qi': 0, 'qo': 1}
receive: {'sr': {'stat': 3}}

send: M100({do1mo:1})
receive: {'r': {}, 'f': [1, 0, 16]}
receive: {'qr': 47, 'qi': 1, 'qo': 0}
receive: {'qr': 48, 'qi': 0, 'qo': 1}
receive: {'sr': {'stat': 3, 'do1mo': 1}}

I would like to check this with you, and see if you guys have any suggestion.

Thank you very much

[justinclift]

Hmmm, I wonder if this is related to #367?

[smhty]

Hi Justin,
Good point.
I actually send the command in a line format (not json), and I don't see similar behavior in the 100.026 version.
I am using the 100.03, because it works well with issue #346

[justinclift]

Ouch. Sounds like things are in a bit of a buggy state atm then. Ugh. 😦

[giseburt]

This is a bug. There should be a: sr_request_status_report(SR_REQUEST_TIMED); After right before the output exits, here: https://github.com/synthetos/g2/blob/edge/g2core/gpio.cpp#L510 That will tell the status report subsystem to update and output anything that’s changed. If you feel comfortable with gut you can make that change, test it, and open a pull request. Either way thank you for pointing this out. I’m not sure how we didn’t catch it before. Several of us (I believe ShopBot as well) use outputs in status reports, so I guess we were only getting the update when something else changed.

[smhty]

Thanks @giseburt for your comment.
I applied your comment, but still don't see any difference.
It makes sense to me: I compared both master and edge versions of the gpio.cpp and if I am right, io_get_output is similar in both versions, and in master io_get_output does not call any sr_request_status_report(SR_REQUEST_TIMED);
So, I don't think that's the source of the problem.
This is just a guess :)

[justinclift]

Just make a PR with that change, here #376.

@smhty Would you be ok to test it? I don't have any CNC nor Due hardware handy atm. Oops. 🙄

[smhty]

@justinclift, I already did it. As you mentioned, it compiles fine but still doesn't update outputs.
I will do it again tomorrow, and let you know if I see any difference.
Thanks again for all your help, and suggestion.

[justinclift]

Heh Heh Heh

My bad. I didn't see your comment in time mentioning that. I was creating the PR at the same time.

It sounds like that PR will need a bit more work then. 😉