Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show contacts/profile onboarding if wallet was recovered from a backup #398

Closed
limpbrains opened this issue Sep 20, 2022 · 4 comments · Fixed by #1297
Closed

Do not show contacts/profile onboarding if wallet was recovered from a backup #398

limpbrains opened this issue Sep 20, 2022 · 4 comments · Fixed by #1297
Assignees
Labels
bug Something isn't working
Milestone

Comments

@limpbrains
Copy link
Collaborator

Describe the bug
I wave a wallet with slashtags profile and a list of contacts. When I recover it from a seed it gets my profile and contacts list just fine. But when I click on a contacts button, it shows contacts onboarding screens. Same for Profile.
I think this can be skipped.

@limpbrains limpbrains added the bug Something isn't working label Sep 20, 2022
@Nuhvi
Copy link
Collaborator

Nuhvi commented Sep 20, 2022

Hmmm, I will test this again after Bitkit backpack backup is in place, it should be how this problem is solved! (restoring Redux state)

@MiguelMedeiros MiguelMedeiros added this to the v0.0.1 milestone Sep 20, 2022
@BitcoinErrorLog
Copy link
Contributor

This seems to have gotten a little bit worse. In a restored wallet, you can no longer see your normal profile screen. It always forces you into the Edit mode, with no way to close the editor.
telegram-cloud-photo-size-1-5118492709567441594-y

@Nuhvi
Copy link
Collaborator

Nuhvi commented Feb 8, 2023

@BitcoinErrorLog I think this is a separate error, which has to do with the fact that having many links push the save button too low. opened #879

But yes you shouldn't go through the onboarding anyway if you are restoring from Bitkit.

The question is, how can we till if the restored wallet was indeed made in Bitkit previously?
The best I can do here is either:
1- Make the assumption and never show the onboarding to anyone restoring a wallet.
2- If they are restoring online, and they created profile / added contacts, and the seeder has their data, and they got it fast enough, then I shouldn't show the onboarding.

Any ideas?

@Nuhvi
Copy link
Collaborator

Nuhvi commented Feb 8, 2023

Apparently, #706 should solve this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants