Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-keychain fork update #2332

Closed
ovitrif opened this issue Nov 5, 2024 · 1 comment · Fixed by synonymdev/react-native-keychain#2
Closed

react-native-keychain fork update #2332

ovitrif opened this issue Nov 5, 2024 · 1 comment · Fixed by synonymdev/react-native-keychain#2
Assignees

Comments

@ovitrif
Copy link
Contributor

ovitrif commented Nov 5, 2024

Task to update fork of react-native-keychain on the latest version of the original library.

Reason is to fix slow startup related to Android Strongbox, the main issue is tracked here:

Will also address:

Might need multiple PRs, as the actual delay at startup isn't really fixed yet in the library, but since the code is converted to Kotlin it's possible to fix the hot reload.

PRs:

@ovitrif
Copy link
Contributor Author

ovitrif commented Nov 5, 2024

Moving this to in review, will create a new issue if there's new changes upstream.

Going this route since my PR for original library might also get merged sooner, so in best case scenario we can switch back to use the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant