Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lottie Exporter] Code cleanup for Lottie exporter plugin #1199

Merged

Conversation

saurabh-ramola
Copy link
Member

Cleaned up the code for Lottie Exporter plugin according to the LGTM active alerts.
Link for the alerts : LGTM alerts for the Lottie Exporter plugin

@saurabh-ramola
Copy link
Member Author

@AnishGG @ice0 , as advised by you, I have added some changes to the Lottie Exporter plugin code based on the LGTM active alerts.
So far I have only added the changes which were tagged as recommendations.
I will be adding the changes tagged as warnings soon.

@lgtm-com
Copy link

lgtm-com bot commented Mar 6, 2020

This pull request fixes 60 alerts when merging d793b3e into 4f6e09c - view on LGTM.com

fixed alerts:

  • 60 for Unused import

@ice0 ice0 merged commit 7d83a44 into synfig:master Mar 7, 2020
@ice0
Copy link
Collaborator

ice0 commented Mar 7, 2020

Awesome!
Merged. Thank you!

@AnishGG
Copy link
Member

AnishGG commented Mar 9, 2020

NOTE: Related to #958

rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 8, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit that referenced this pull request Jul 12, 2021
- Convert methods not working with radius of simple circle layer (#1101)
- [Lottie exporter] Add support for variable gamma correction (#1174)
- Changes made to offsetKeyFrame file (#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (#1236 #1254 #1286 #1363 #1409 #1447 #1446 #1516 #1515 #1593 #1586 #1619 #1606 #1650 #1587)
- Add support for blur layers (#1505)
- Add support for Outline layer without variable widths (#1647)
- Improve support for exported values (#2182)
- Some code cleanup (#1199 #1213 #1226 #1456 #2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants