fix: crash with a bline containing only 2 points that are too close #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possible issue fixed: #2276 |
ice0
changed the title
ice0
changed the title
I don't know :) |
ice0
reviewed
Oct 20, 2022
ice0
previously approved these changes
Oct 20, 2022
distance[n-1] would be zero, and make the WidthPoint position to be NaN That problem is propagated, affects synfig::hom_to_std() and a crash happens How to reproduce: with Draw Tool and a drawing tablet, quickly tap twice (or more in a row) at the same point. Synfig Studio crashes.
rodolforg
force-pushed
the
avoid-crash-nan
branch
from
8f90dd8
to
749a421
Compare
ice0
approved these changes
May 5, 2023
|
Merged. Thank you! |
morevnaproject
pushed a commit
that referenced
this pull request
Apr 14, 2024
…2855) distance[n-1] would be zero, and make the WidthPoint position to be NaN That problem is propagated, affects synfig::hom_to_std() and a crash happens How to reproduce: with Draw Tool and a drawing tablet, quickly tap twice (or more in a row) at the same point. Synfig Studio crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent crash due to NaN with a bline containing only 2 points that are too close
distance[n-1] would be zero, and make the WidthPoint position to be NaN
That problem is propagated, affects
synfig::hom_to_std()and a crash happensHow to reproduce: with Draw Tool and a drawing tablet, quickly tap twice (or more in a row) at the same point. Synfig Studio crashes.