SVG: fix parser for <path> element (except for A commands) #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodolforg
changed the title
|
This pull request introduces 1 alert when merging b57ed2a into 576c349 - view on LGTM.com new alerts:
|
rodolforg
force-pushed
the
svg-path-d
branch
from
b57ed2a
to
a3e7861
Compare
|
Last push was to fix LGTM alert. |
rodolforg
force-pushed
the
svg-path-d
branch
from
a3e7861
to
31bce64
Compare
ice0
reviewed
Oct 18, 2021
ice0
previously approved these changes
Oct 20, 2021
|
@rodolforg please rebase |
There was no point at all
Replace `actual_` with `current_`, because latter correctly says what those variables actually mean. In some Latin languages "current" could be translated as "atual" (e.g., Spanish and Portuguese). Original coder made a mistake when he chose the English word "actual" ;)
|
@ice0 rebased |
ice0
approved these changes
Oct 26, 2021
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I try to fix all inconsistencies I found in implementation for each
<path>command, except forAanda.Specs:
SVG 1.1: https://www.w3.org/TR/SVG11/paths.html
SVG 2: https://www.w3.org/TR/SVG/paths.html