[Studio] Fixed crash in debug builds when right-clicking on some waypoints #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The crash affects 1.4.x branch too, but only for debug builds. |
It only makes sense in this case. Debug builds crash otherwise due to an assert in find_param_desc(). Reported by GregorysonofCarl here: https://forums.synfig.org/t/crash-when-right-clicking-waypoints/12391/6
rodolforg
force-pushed
the
fix-waypoint-dialog-setup
branch
from
8c79cc5
to
bb247d2
Compare
|
Force pushed to improve the commit message only. |
ice0
reviewed
Jul 19, 2021
| @@ -254,8 +254,9 @@ void Widget_Waypoint::set_valuedesc(synfigapp::ValueDesc& value_desc) | |||
|
|
|||
| value_widget->set_value_desc(value_desc); | |||
| synfig::ParamDesc param_desc; | |||
| if (value_desc.find_param_desc(param_desc)) | |||
| value_widget->set_param_desc(param_desc); | |||
| if (value_desc.parent_is_layer()) | |||
There was a problem hiding this comment.
It looks like it should be:
if (value_desc.parent_is_layer()) {
value_desc.find_param_desc(param_desc);
value_widget->set_param_desc(param_desc);
}
?
There was a problem hiding this comment.
I thought so, but we use a lot of dialogs that are kept hidden/shown during the whole application lifetime. So I thought it would be safer to reset param_desc.
ice0
approved these changes
Jul 19, 2021
ice0
changed the title
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only makes sense in this case.
Debug builds crash otherwise due to an assert in find_param_desc().
Reported by GregorysonofCarl here:
https://forums.synfig.org/t/crash-when-right-clicking-waypoints/12391/6