Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synfig Studio] The canvas properties dialog now displays values correctly after being closed with the window close button. #2076

Merged
merged 2 commits into from
Mar 25, 2021
Merged

[Synfig Studio] The canvas properties dialog now displays values correctly after being closed with the window close button. #2076

merged 2 commits into from
Mar 25, 2021

Conversation

rChen10
Copy link
Contributor

@rChen10 rChen10 commented Mar 23, 2021

Refresh was being called by CanvasProperties directly rather than being connected to signal_show() as demonstrated in CanvasOptions.

This is my first pull request, so any feedback is appreciated.

@ice0 ice0 changed the title Resolve issue #2014 (CanvasProperties did not properly reset on delete) [Synfig Studio] Canvas properties now properly undo changes when closed with the window's close button. Mar 25, 2021
@ice0 ice0 changed the title [Synfig Studio] Canvas properties now properly undo changes when closed with the window's close button. [Synfig Studio] Canvas properties dialog now properly undo changes when closed with the window's close button. Mar 25, 2021
@ice0 ice0 added the GUI label Mar 25, 2021
@ice0 ice0 changed the title [Synfig Studio] Canvas properties dialog now properly undo changes when closed with the window's close button. [Synfig Studio] The canvas properties dialog now correctly displays changes after being closed with the window close button. Mar 25, 2021
@ice0 ice0 changed the title [Synfig Studio] The canvas properties dialog now correctly displays changes after being closed with the window close button. [Synfig Studio] The canvas properties dialog now displays values correctly after being closed with the window close button. Mar 25, 2021
@ice0 ice0 merged commit 431ab77 into synfig:master Mar 25, 2021
@ice0
Copy link
Collaborator

ice0 commented Mar 25, 2021

Merged. Thank you!

DhairyaBahl pushed a commit to DhairyaBahl/synfig that referenced this pull request Mar 25, 2021
@rChen10 @DhairyaBahl
[Synfig Studio] The canvas properties dialog now displays values corr…
935e477 
…ectly after being closed with the window close button. (synfig#2076)

* Resolve issue synfig#2014 by attaching refresh to signal_show rather than calling refresh directly.

* Removed unecessary comment. Resolves synfig#2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keyikedalube Keyikedalube Keyikedalube approved these changes

@ice0 ice0 ice0 approved these changes

Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rChen10 @ice0 @Keyikedalube