Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Fixed path for splash screen image and added Adwaita icons for MSYS2 builds. #1689

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

AYESDIE
Copy link
Member

@AYESDIE AYESDIE commented Sep 1, 2020

Fixes the issue raised here in #1058.

@FirasH
Copy link
Member

FirasH commented Sep 1, 2020

I've completely reinstalled msys and rebuilt your branch, but still the interface has the same missing icons and missing splash screen.

I have no idea if there's an issue on my side, but my system is vanilla (just the programs I use, not even the antivirus)

@AYESDIE
Copy link
Member Author

AYESDIE commented Sep 1, 2020

It doesn't have anything to do with the antivirus. After you run the cmake command, can you go and check whether there's /cmake-build-msys/output/share/icons/Adwaita folder in there. It should be there after you run the cmake command. Also, in this case, if there's no source (which means you've not installed that dependency, it should fail at the cmake part).

For me, on running the ./2-build-msys-cmake.sh, those icons are placed in the correct folder once the cmake part is complete, and the splash screen is placed where it should be as well when it's built.

@AYESDIE
Copy link
Member Author

AYESDIE commented Sep 1, 2020

Even on the appveyor build, the splash screen is generated into the correct folder here.

@ice0 ice0 changed the title Fixed path for splash screen and added Adwaita icons for MSYS2 builds. [CMake] Fixed path for splash screen image and added Adwaita icons for MSYS2 builds. Sep 2, 2020
@ice0 ice0 added the CMake label Sep 2, 2020
@ice0 ice0 merged commit e7441e4 into synfig:master Sep 2, 2020
@ice0
Copy link
Collaborator

ice0 commented Sep 2, 2020

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants