Toolbar menu #1386
Merged
Toolbar menu #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARYA-BHARDWAJ
force-pushed
the
toolbar_menu
branch
from
7740f60
to
9b72731
Compare
|
@ice0 please have a look |
|
Looks good to me. @morevnaproject should the command show/hide the toolbar for all windows or only for the selected one? |
|
If you ask me I think it's more of like preference so if I hide, it should
not be visible in other windows as well.
However as every window have it's own toolbar so I'm not sure if this is
what is expected.
If we go with 1st option then we should not have separate toolbar for every
window.
…On Wed, Apr 29, 2020, 4:47 PM ice0 ***@***.***> wrote:
Looks good to me.
@morevnaproject <https://github.com/morevnaproject> should the command
show/hide the toolbar for all windows or only for the selected one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1386 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7ACH7XJGYEBPFVTGSYNLDRPAEDNANCNFSM4MSULROQ>
.
|
|
Reviewing now! ^__^ |
morevnaproject
requested changes
May 1, 2020
ARYA-BHARDWAJ
force-pushed
the
toolbar_menu
branch
from
f1637b5
to
889b3ca
Compare
ARYA-BHARDWAJ
force-pushed
the
toolbar_menu
branch
from
cf8307e
to
9b72731
Compare
|
@ARYA-BHARDWAJ Looks good to me now! Can you please rebase your branch on top of current master, so I can make a clean merge? |
morevnaproject
approved these changes
May 2, 2020
|
@morevnaproject I have rebased the branch on top of current master. I hope this branch can be merged now. |
|
@ARYA-BHARDWAJ Hmm... I see it is still not rebased yet. Please make sure that you fetched the latest master commits. You can do this with following commands (I assume that you have main synfig repo as "upstream" remote): |
ARYA-BHARDWAJ
force-pushed
the
toolbar_menu
branch
from
0a5938b
to
af4b833
Compare
|
@morevnaproject sorry my bad I forget to push. I hope I have done it correctly |
|
Merged now. Thank you! ^__^ |
ice0
pushed a commit
to ice0/synfig
that referenced
this pull request
Dec 30, 2020
Merged
ice0
pushed a commit
to ice0/synfig
that referenced
this pull request
Feb 28, 2021
morevnaproject
added a commit
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is regarding issue no #733. Now "View" -> "Toolbar" menu item is active.