Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vectorization] Bezier enhance #1240

Merged
merged 7 commits into from
Jul 7, 2020
Merged

[Vectorization] Bezier enhance #1240

merged 7 commits into from
Jul 7, 2020

Conversation

ARYA-BHARDWAJ
Copy link
Contributor

@ARYA-BHARDWAJ ARYA-BHARDWAJ commented Mar 13, 2020 •
edited
Loading

This is regarding issue no #1184 @ice0 please have a look

@AnishGG
Copy link
Member

AnishGG commented Mar 13, 2020

It will be better if you could add [Vectorization] in the beginning of this P.R. ^__^
It seems to be misleading without it.

@ice0
Copy link
Collaborator

ice0 commented Mar 13, 2020

@ankit-kumar-dwivedi can you please take a look?

@ARYA-BHARDWAJ ARYA-BHARDWAJ changed the title Bezier enhance [Vectorization] Bezier enhance Mar 13, 2020
@ankit-kumar-dwivedi ankit-kumar-dwivedi linked an issue Mar 13, 2020 that may be closed by this pull request
[Vectorization] Enhance BezierToOutline function #1184
Closed
@ankit-kumar-dwivedi
Copy link
Member

@ARYA-BHARDWAJ the build failed for me with same errors as in this travis build -> https://travis-ci.com/github/synfig/synfig/jobs/297844389
please make sure the scope of variables are defined properly.

@ARYA-BHARDWAJ
Copy link
Contributor Author

@ankit-kumar-dwivedi please have a look

@ankit-kumar-dwivedi
Copy link
Member

ankit-kumar-dwivedi commented Mar 14, 2020 •
edited
Loading

@ARYA-BHARDWAJ I am getting different results after running vectorization (see below image)
Your version
changed

Previous version
not_changed

Image I used -
line-drawing-of-duck-simple

On further debugging I saw all your bline_point_list have size() == 3
However, in the previous version, it is varied. I suggest you test the feature thoroughly with 2-3 image for

  • number of bline points
  • their size
  • shape of image must not be distorted

@ARYA-BHARDWAJ
Copy link
Contributor Author

@ankit-kumar-dwivedi please have a look now I think it should work now

@ankit-kumar-dwivedi
Copy link
Member

@ice0 we are good to go here!
Good work @ARYA-BHARDWAJ

@ice0
Copy link
Collaborator

ice0 commented Mar 16, 2020

@ARYA-BHARDWAJ Looks good to me. Please squash and rebase commits. And I will merge it.

@ice0 ice0 merged commit d82b5ae into synfig:master Jul 7, 2020
@ice0
Copy link
Collaborator

ice0 commented Jul 7, 2020

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankit-kumar-dwivedi ankit-kumar-dwivedi ankit-kumar-dwivedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Vectorization] Enhance BezierToOutline function
4 participants
@ARYA-BHARDWAJ @AnishGG @ice0 @ankit-kumar-dwivedi