Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Connection can't be deleted from connection details #283

Closed
syndesis-bot opened this issue Nov 15, 2017 · 8 comments
Closed

Connection can't be deleted from connection details #283

syndesis-bot opened this issue Nov 15, 2017 · 8 comments
Labels
cat/feature PR label for a new feature cat/starter An issue which is easy to solve and can be used for ramping up new developers group/ui User interface SPA, talking to the REST backend prio/p2 The priority of a bug. p1 means low status/stale Issue considered to be stale so that it can be closed soon

Comments

@syndesis-bot
Copy link
Collaborator

@mcada 2017-11-06 enhancement, good first issue, UX Design

I think it should be possible to delete connection if you are in connection details. It is possible to delete integration from integration details.

@syndesis-bot syndesis-bot added cat/enhancement cat/starter An issue which is easy to solve and can be used for ramping up new developers group/ui User interface SPA, talking to the REST backend notif/uxd Ping UX team that UX related changes are involved labels Nov 15, 2017
@syndesis-bot
Copy link
Collaborator Author

@gashcrumb 2017-11-06

+1

@dongniwang If we add this would it make sense to have a delete button in a similar location as the integration details?

@syndesis-bot
Copy link
Collaborator Author

@dongniwang 2017-11-06

Agreed that we should have the ability to delete a connection from the connection details page.

But I think the delete button should probably be placed at the breadcrumb/toolbar level.

Integration details page is being reworked at the moment, will need to align button placement for these two pages.

@amysueg amysueg added notif/uxd Ping UX team that UX related changes are involved and removed notif/uxd Ping UX team that UX related changes are involved labels Jan 10, 2018
@amysueg
Copy link

amysueg commented Jan 10, 2018

@sjcox-rh will add a screenshot showing the original design with delete button included.

@sjcox-rh
Copy link
Contributor

Sorry for the delay, here is the screenshot of the original design for the OAuth flow. There is a "Delete Connection" button located in the breadcrumb/toolbar level.

@gashcrumb @dongniwang @amysueg

screen shot 2018-01-18 at 12 54 59 pm

@sjcox-rh sjcox-rh removed the notif/uxd Ping UX team that UX related changes are involved label Jan 18, 2018
@gashcrumb
Copy link
Contributor

One thing on this, should you be able to delete a connection that is in use.

If not, we'll need to introduce that into the Connection model, the number of integrations using that connection and hide the button.

If you're supposed to be able to delete a connection that's being used by integrations, what's supposed to happen?

@gashcrumb gashcrumb added prio/p3 prio/p2 The priority of a bug. p1 means low and removed prio/p3 labels Mar 16, 2018
@gashcrumb gashcrumb added this to the Backlog milestone Mar 19, 2018
@gashcrumb gashcrumb added cat/feature PR label for a new feature and removed cat/enhancement labels Mar 26, 2018
@mcoker
Copy link
Contributor

mcoker commented Jun 13, 2018

@gashcrumb This will be introduced as part of the updates to the connection template. Can we go ahead and close this issue and create a new issue after #2212 is verified, or should we leave it open and use this issue to introduce that change?

@gashcrumb
Copy link
Contributor

I think we can keep this issue around, now it's linked :-)

@heiko-braun heiko-braun modified the milestone: Backlog Aug 27, 2018
@stale
Copy link

stale bot commented Nov 25, 2018

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale Issue considered to be stale so that it can be closed soon label Nov 25, 2018
@stale stale bot closed this as completed Dec 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/feature PR label for a new feature cat/starter An issue which is easy to solve and can be used for ramping up new developers group/ui User interface SPA, talking to the REST backend prio/p2 The priority of a bug. p1 means low status/stale Issue considered to be stale so that it can be closed soon
Projects
None yet
Development

No branches or pull requests

6 participants