From ab11663fb2d43b29ee11dcfa1c6769e529f6b7d6 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Mon, 20 May 2024 01:15:01 +0900
Subject: [PATCH] Allow d in short names (#116)

---
 src/ObjectCalisthenics/Rules/NoShortNameRule.php          | 5 ++++-
 .../Rules/NoShortNameRule/Fixture/AllowD.php              | 8 ++++++++
 .../Rules/NoShortNameRule/NoShortNameRuleTest.php         | 6 ++++--
 .../Rules/NoShortNameRule/config/configured_rule.neon     | 1 +
 4 files changed, 17 insertions(+), 3 deletions(-)
 create mode 100644 tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php

diff --git a/src/ObjectCalisthenics/Rules/NoShortNameRule.php b/src/ObjectCalisthenics/Rules/NoShortNameRule.php
index 505ad4af..7c83cda3 100644
--- a/src/ObjectCalisthenics/Rules/NoShortNameRule.php
+++ b/src/ObjectCalisthenics/Rules/NoShortNameRule.php
@@ -36,7 +36,7 @@ final class NoShortNameRule extends AbstractSymplifyRule implements Configurable
      */
     public function __construct(
         private readonly int $minNameLength,
-        private readonly array $allowedShortNames = ['i', 'j', 'y', 'z']
+        private readonly array $allowedShortNames = ['i', 'j', 'y', 'z', 'd', 'dd']
     ) {
     }
 
@@ -130,6 +130,9 @@ private function isNameValid(string $name): bool
             return true;
         }
 
+        dump($name);
+        dump(in_array($name, $this->allowedShortNames, true));
+
         return in_array($name, $this->allowedShortNames, true);
     }
 }
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php
new file mode 100644
index 00000000..1ad227fd
--- /dev/null
+++ b/tests/ObjectCalisthenics/Rules/NoShortNameRule/Fixture/AllowD.php
@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+function d()
+{
+    // handle dump
+}
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php b/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php
index c5c9641c..ae3d6624 100644
--- a/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php
+++ b/tests/ObjectCalisthenics/Rules/NoShortNameRule/NoShortNameRuleTest.php
@@ -26,13 +26,15 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipId.php', []];
 
         $errorMessage = sprintf(NoShortNameRule::ERROR_MESSAGE, 'em', 3);
-        $yeErrorMEssage = sprintf(NoShortNameRule::ERROR_MESSAGE, 'YE', 3);
-        yield [__DIR__ . '/Fixture/ShortNamingClass.php', [[$errorMessage, 9], [$yeErrorMEssage, 11]]];
+        $yeErrorMessage = sprintf(NoShortNameRule::ERROR_MESSAGE, 'YE', 3);
+        yield [__DIR__ . '/Fixture/ShortNamingClass.php', [[$errorMessage, 9], [$yeErrorMessage, 11]]];
 
         $errorMessage = sprintf(NoShortNameRule::ERROR_MESSAGE, 'n', 3);
         yield [__DIR__ . '/Fixture/ShortClosureParam.php', [[$errorMessage, 11]]];
         yield [__DIR__ . '/Fixture/ShortParam.php', [[$errorMessage, 9]]];
 
+        yield [__DIR__ . '/Fixture/AllowD.php', []];
+
         $errorMessage = sprintf(NoShortNameRule::ERROR_MESSAGE, 'n', 3);
         yield [
             __DIR__ . '/Fixture/ShortAssignParameter.php',
diff --git a/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon b/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon
index d6dfcdb9..c918b33b 100644
--- a/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon
+++ b/tests/ObjectCalisthenics/Rules/NoShortNameRule/config/configured_rule.neon
@@ -9,3 +9,4 @@ services:
             minNameLength: 3
             allowedShortNames:
                 - id
+                - d