From 58c8dbf7bc5be2818ca2616c82839e260d34b525 Mon Sep 17 00:00:00 2001
From: Carlos Granados <barel.barelon@gmail.com>
Date: Thu, 22 Aug 2024 15:34:08 +0200
Subject: [PATCH] Change NoReturnArrayVariableListRule to ignore array spreads
 (#139)

---
 src/Rules/NoReturnArrayVariableListRule.php      |  4 ++++
 .../Fixture/SkipArraySpreads.php                 | 16 ++++++++++++++++
 .../NoReturnArrayVariableListRuleTest.php        |  1 +
 3 files changed, 21 insertions(+)
 create mode 100644 tests/Rules/NoReturnArrayVariableListRule/Fixture/SkipArraySpreads.php

diff --git a/src/Rules/NoReturnArrayVariableListRule.php b/src/Rules/NoReturnArrayVariableListRule.php
index 5a66536a..f5055602 100644
--- a/src/Rules/NoReturnArrayVariableListRule.php
+++ b/src/Rules/NoReturnArrayVariableListRule.php
@@ -156,6 +156,10 @@ private function resolveExprCount(Array_ $array): int
                 continue;
             }
 
+            if ($item->unpack === true) {
+                continue;
+            }
+
             ++$exprCount;
         }
 
diff --git a/tests/Rules/NoReturnArrayVariableListRule/Fixture/SkipArraySpreads.php b/tests/Rules/NoReturnArrayVariableListRule/Fixture/SkipArraySpreads.php
new file mode 100644
index 00000000..d3ba8d92
--- /dev/null
+++ b/tests/Rules/NoReturnArrayVariableListRule/Fixture/SkipArraySpreads.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\NoReturnArrayVariableListRule\Fixture;
+
+final class SkipArraySpreads
+{
+    public function run($value)
+    {
+        $a = [1, 2, 3];
+        $b = [4, 5, 6];
+        return [...$a, ...$b];
+    }
+}
+
diff --git a/tests/Rules/NoReturnArrayVariableListRule/NoReturnArrayVariableListRuleTest.php b/tests/Rules/NoReturnArrayVariableListRule/NoReturnArrayVariableListRuleTest.php
index 671f31c9..8c4995c1 100644
--- a/tests/Rules/NoReturnArrayVariableListRule/NoReturnArrayVariableListRuleTest.php
+++ b/tests/Rules/NoReturnArrayVariableListRule/NoReturnArrayVariableListRuleTest.php
@@ -30,6 +30,7 @@ public static function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SkipNews.php', []];
         yield [__DIR__ . '/Fixture/ValueObject/SkipValueObject.php', []];
         yield [__DIR__ . '/Fixture/SkipParentMethod.php', []];
+        yield [__DIR__ . '/Fixture/SkipArraySpreads.php', []];
     }
 
     /**