Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow less-loader v9 #983

Merged
merged 2 commits into from
May 31, 2021
Merged

Allow less-loader v9 #983

merged 2 commits into from
May 31, 2021

Conversation

bobvandevijver
Copy link
Contributor

I'm not sure what the policy on node compatibility is, but the latest major of less-loader only seems to drop Node 10 support (release notes).

Webpack Encore still supports Node 10, but that should still be possible if you use one of the other allowed less loaders.

@weaverryan
Copy link
Member

You're correct - there's no problem with allowing less-loader 9, as we still allow versions that support Node 10.

However, it's definitely made a mess for the tests. I've just pushed what will hopefully be a workaround.

@bobvandevijver
Copy link
Contributor Author

Well, Node 10 is no longer supported since the beginning of this month, so we could consider dropping support for it altogether if that makes it easier 😀

@weaverryan
Copy link
Member

I’m concerned about ubuntu 20.04 LTS, which I believe comes with node 10. And to bump to 12 just for this reason would be unfortunate :)

@weaverryan
Copy link
Member

Plus, I think my last commit fixed things. Appveyor is broken still, but I’m not sure we need to anymore, as we have windows tested by GH actions.

@bobvandevijver
Copy link
Contributor Author

@weaverryan Is there anything left to do for me before this can be merged and released?

@weaverryan
Copy link
Member

Thank you Bob!

@weaverryan weaverryan merged commit 37c6b37 into symfony:main May 31, 2021
@bobvandevijver bobvandevijver deleted the less-loader-9 branch June 1, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants