Upgrade file-loader and allowed version for url-loader, drop Node 8 support #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weaverryan
commented
Apr 17, 2020
weaverryan
commented
- Upgrades file-loader from v1 to v6
- Upgrades url-loader from allowing v1 or v2 to v4
- Removes support for Node 8
Kocal
added a commit
to Kocal/webpack-encore
that referenced
this pull request
Apr 17, 2020
eslint-loader is the last version to [support both ESLint 5 and 6](https://github.com/webpack-contrib/eslint-loader/blob/v3.0.4/package.json#L40). Given the [changelog for v3.0.0](https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#300-2019-08-24), the only breaking changes are: - drop support for Node < 8.9.0 (we did it too symfony#731) - minimum supported webpack version is 4: not a problem - minimum supported eslint version is 5: not a problem
weaverryan
pushed a commit
to Kocal/webpack-encore
that referenced
this pull request
Apr 18, 2020
eslint-loader is the last version to [support both ESLint 5 and 6](https://github.com/webpack-contrib/eslint-loader/blob/v3.0.4/package.json#L40). Given the [changelog for v3.0.0](https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#300-2019-08-24), the only breaking changes are: - drop support for Node < 8.9.0 (we did it too symfony#731) - minimum supported webpack version is 4: not a problem - minimum supported eslint version is 5: not a problem
weaverryan
added a commit
that referenced
this pull request
Apr 18, 2020
This PR was merged into the master branch. Discussion ---------- build(deps-dev): update eslint-loader to ^3 eslint-loader ^3 is the last version to [support both ESLint 5 and 6](https://github.com/webpack-contrib/eslint-loader/blob/v3.0.4/package.json#L40) (related #732). Given the [changelog for v3.0.0](https://github.com/webpack-contrib/eslint-loader/blob/master/CHANGELOG.md#300-2019-08-24), the only breaking changes are: - drop support for Node < 8.9.0 (we did it too #731) - minimum supported webpack version is 4: not a problem - minimum supported eslint version is 5: not a problem Commits ------- bd641a9 build(deps-dev): update eslint-loader to ^3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.