Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to configure devServer options #693

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Add a way to configure devServer options #693

merged 1 commit into from
Mar 20, 2020

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Feb 7, 2020

Hi :)

This PR is a proposal for #692. It add a new method Encore.configureDevServerOptions() for configuring the webpack dev-server.

Example:

Encore
  // ...
  .configureDevServerOptions(options => {
    options.https = {
      key: '...',
      cert: '...',
    };
  })

I've installed chai-subet for asserting objects (it's more readable and easy to do), but I can remove it if it's not wanted. 👍

@Kocal Kocal mentioned this pull request Feb 7, 2020
Closed
@Kocal Kocal changed the title feat: add a way to configure devServer options Add a way to configure devServer options Feb 7, 2020
Lyrkan
Lyrkan approved these changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kocal, I only have a really minor comment :)

index.js Outdated Show resolved Hide resolved
@weaverryan weaverryan force-pushed the feat/configure-dev-server-options branch from b483eed to 6d2730e Compare March 20, 2020 14:23
@weaverryan
Copy link
Member

Very nice - thank you @Kocal!

@weaverryan weaverryan merged commit bdf8ba4 into symfony:master Mar 20, 2020
@Kocal Kocal deleted the feat/configure-dev-server-options branch March 20, 2020 14:28
@Kocal Kocal mentioned this pull request Mar 28, 2020
Merged
@Kocal
Copy link
Member Author

Kocal commented Mar 28, 2020

PR Doc: symfony/symfony-docs#13433

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 30, 2020
@javiereguiluz
minor #13433 Encore: add documentation for Encore.configureDevServerO…
0c93d1c 
…ptions() (Kocal)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #13433).

Discussion
----------

Encore: add documentation for Encore.configureDevServerOptions()

Hi 👋,

This PR add documention for the new method `Encore.configureDevServerOptions()` implemented in symfony/webpack-encore#693.

Thanks :)

Commits
-------

869727d Encore: add documentation for Encore.configureDevServerOptions()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyrkan Lyrkan Lyrkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kocal @weaverryan @Lyrkan