Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing @hotwired/stimulus, allowing @symfony/stimulus-bridge 3, dropping v1 #1062

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

weaverryan
Copy link
Member

Hi!

This does 3 things:

  1. Allows @hotwired/stimulus when working with enableStimulusBridge(). More precisely, it just removes the requirement of Stimulus entirely... it's not technically needed in THIS library.

  2. Add support for the upcoming @symfony/stimulus-bridge version 3

  3. Drop support for @symfony/stimulus-bridge version 1

@stof
Copy link
Member

stof commented Dec 1, 2021

tests are broken, because the tests are written expecting v3 of the bridge (as they use stimulus 3) while the yarn.lock contains v2 of the bridge.

@stof
Copy link
Member

stof commented Dec 1, 2021

given that @symfony/stimulus-bridge 3 is not released yet, the CI is just skipping the tests now

@weaverryan
Copy link
Member Author

given that @symfony/stimulus-bridge 3 is not released yet, the CI is just skipping the tests now

You're too fast Stof! I was typing the below message when your message popped up :).

I've just skipped the test for stimulus-bridge 2.0 (we COULD create a completely separate test for stimulus v2, but it would require duplicating a fixtures directory and adding another "fake" package to package.json - I don't think it's worth it). Locally, I temporarily forced the latest (eventually v3) version of stimulus-bridge and the test passes.

<hello></hello>
</div>
</template>

<script lang="ts">
import Hello from './components/Hello.vue'
import logoPath from './assets/logo.png';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the package.json files are unrelated, but fix the tests. I'm not sure what's going on - it's super complex. It relates to this commit - vuejs/vue-loader@21725a4 - and vue-loader 16.7.0. Our testing setup is very vanilla, but for some reason, the <img src="./assets/logo.png"> no longer worked. I have no idea how to fix that - and it's so strange, that, for now, I'm going to assume it's some edge-case issue specific to our app or some bug that will be fixed upstream.

@weaverryan
Copy link
Member Author

This is ready to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants