Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing position of host option for webpack-dev-server #1031

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

weaverryan
Copy link
Member

Fixes #1017

But, I would love some real-world testing :). It looks like I had this option in the wrong spot. Or, it was allowed in this spot in an earlier version of 4 beta, but now it has this proper spot.

Cheers!

@weaverryan weaverryan mentioned this pull request Aug 31, 2021
@bobvandevijver
Copy link
Contributor

Would it be possible for you to create a beta release on npm so it is easy to install and test for me tomorrow?

@Kocal
Copy link
Member

Kocal commented Sep 1, 2021

@bobvandevijver you can run the following commands instead of waiting for a release:

$ yarn remove @symfony/webpack-encore
$ yarn add -D symfony/webpack-encore#1031/head

@bobvandevijver
Copy link
Contributor

bobvandevijver commented Sep 1, 2021

@Kocal You're absolutely right!

So, I made the following adjustment:

-    .configureDevServerOptions(options => {
-      options.disableHostCheck = true;
-    })
-
     .configureDevServerOptions(options => {
       options.allowedHosts = 'all';
       options.https = {
         cert: '/etc/apache2/ssl/domain.dev/fullchain.pem',
         key: '/etc/apache2/ssl/domain.dev/privkey.pem',
       };
-
-      delete options.client.host;
     })

It still seems to work as it should in my environment (except for vuejs/vue-loader#1795, but that is unrelated to #1017).

@weaverryan weaverryan merged commit 3598b18 into symfony:main Sep 3, 2021
@weaverryan weaverryan deleted the fix-dev-server-stable branch September 3, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected]
3 participants