Version 1.0 problems in manifest.json when importing from composer vendor folder #907
Comments
|
This all seems to be related with the There are other issues too that might be related (see current list of issues in https://github.com/shellscape/webpack-manifest-plugin/issues). I fear that the |
|
Hi everyone! Thanks for the issue and the detailed update @ureimers - that's very helpful! I need to dig deeper, but since we need to get this fixed, I see 2 options:
If anyone wants to play with Cheers! |
|
Hi @weaverryan, glad I could help kicking this off.
I'm not sure if I get the naming right here, but every single mapped asset would need to be a bundle name, and the result would have a lot of superfluous "asset_kind" keys. For example: It's possible, but it doesn't quite seem to be the right format. What do you think? Regards, Ulf |
|
If you're having this problem, could you please test #921 and tell me if it works for you or doesn't work for you? Thanks! |
It works great the output is the same as version 0.33.0 with the right manifest! |
@weaverryan Looks a lot better now, thank you! There are three issues left: 1. Spritemaps (fixed) This worked in Webpack Encore 0.24 (we hadn't updated in a while) but with the new Webpack Encore 1.0 / webpack-manifest-plugin combination the manifest's source filename would include the
I fixed this by using and modifying the new 2. Stylus assets (no fix needed?) 3. Numerically named files (conditional imports?) They weren't there before (Encore 0.24) and are only created in a production build. As they are minified it's not that easy to find their source files but I was able to locate the .css file: It's conditionally imported inside a .vue file which itself is imported in a .js file which is added as an entry to Encore (Encore.addEntry() -> .js file -> import -> .vue file -> if() import -> .css file). I'll try to investigate this further. |
|
@ureimers if fonts are referenced from the CSS, they don't need to be in the map (as the map is meant for usages in Symfony's The fact that they are in the map is related to a change in webpack-manifest-plugin that is being reverted (see the associated PR). |
|
@stof You're absolutely right: As the hashed font names are already written into all built assets they aren't needed in the manifest. Which associated PR did you mean? shellscape/webpack-manifest-plugin#249 doesn't seem to revert a change to webpack-manifest-plugin but that's the only "hot" PR I can see (and am watching) right now. Btw. @weaverryan Great work so far Sherlock! Following your track of comments and findings through the different packages (webpack-manifest-plugin, as well as webpack itself) is like reading an investigative story :-) Sorry to hear, that npm on Windows almost killed you ;-) |
|
Hey @ureimers!
Ha! I'm super happy to know that someone else followed that rabbit hole of insanity! Thanks for the nice words :)
I think this might, unfortunately, be the "correct" solution. That
If you build in "dev" mode, these should have super long names - like
My PR has rapidly changed in the past 36 hours :) Cheers! |
|
Hi! Please try version 1.0.6: https://github.com/symfony/webpack-encore/releases/tag/v1.0.6 If you continue to have any Cheers! |
|
Great you fixed this pretty fast with much work! 👍 |
Hello I'm trying to update sylius webpack encore to 1.0.3 but the manifest.json is all wrong, maybe it's because sylius entry point is a javascript that imports files from vendor?
This is the entry point.
syliusis inside vendor.and the content of manifest.json is this
Should be this
The text was updated successfully, but these errors were encountered: