Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated 'datettime' Form Type #6608

Closed
wants to merge 1 commit into from
Closed

deprecated 'datettime' Form Type #6608

wants to merge 1 commit into from

Conversation

dsmink
Copy link
Contributor

@dsmink dsmink commented May 23, 2016

'datettime' to DateTimeType::class

@dsmink
deprecated 'datettime' Form Type
38f1fdc 
'datettime' to DateTimeType::class
@xabbuh
Copy link
Member

xabbuh commented May 23, 2016

👍

@javiereguiluz
Copy link
Member

👍

@javiereguiluz javiereguiluz mentioned this pull request May 24, 2016
Closed
@OskarStark
Copy link
Contributor

typo in the commit message -> datettime, same in the PR title and the PR body

@wouterj
Copy link
Member

wouterj commented May 27, 2016

Thanks @dsmink, great catch! I've merged this into 2.8, where form type names were deprecated.

wouterj added a commit that referenced this pull request May 27, 2016
@wouterj
bug #6608 deprecated 'datettime' Form Type (dsmink)
d2958ad 
This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closes #6608).

Discussion
----------

deprecated 'datettime' Form Type

'datettime' to DateTimeType::class

Commits
-------

cae7a80 deprecated 'datettime' Form Type
@wouterj wouterj closed this May 27, 2016
@OskarStark
Copy link
Contributor

you missed the typo 😢

@wouterj
Copy link
Member

wouterj commented May 27, 2016

I didn't miss it, but I don't care about typos in git history. The documentation is important, the commits aren't imo.

@OskarStark
Copy link
Contributor

I didn't miss it, but I don't care about typos in git history. The documentation is important, the commits aren't imo.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsmink @xabbuh @javiereguiluz @OskarStark @wouterj