Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null description of query_builder option #6599

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

HeahDude
Copy link
Contributor

@HeahDude
Copy link
Contributor Author

I've opened symfony/symfony#18830

fabpot added a commit to symfony/symfony that referenced this pull request Jun 15, 2016
…s null (HeahDude)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] fixed EntityType test with query_builder option as null

| Q             | A
| ------------- | ---
| Branch?       | 2.8+
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | symfony/symfony-docs#6599

ref #13990 (comment).

Commits
-------

ad8e989 [Form] fixed EntityType test with query_builder option
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull request Jun 15, 2016
…s null (HeahDude)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] fixed EntityType test with query_builder option as null

| Q             | A
| ------------- | ---
| Branch?       | 2.8+
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | symfony/symfony-docs#6599

ref symfony/symfony#13990 (comment).

Commits
-------

ad8e989 [Form] fixed EntityType test with query_builder option
@HeahDude
Copy link
Contributor Author

Ping, symfony/symfony#18830 is merged now.

@xabbuh
Copy link
Member

xabbuh commented Jun 20, 2016

👍

Status: Reviewed

@wouterj wouterj merged commit 14482e4 into symfony:2.8 Jun 20, 2016
wouterj added a commit that referenced this pull request Jun 20, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

Fixed null description of query_builder option

doc fix: 2.8+

ref symfony/symfony#13990 (comment)

Commits
-------

14482e4 Fixed null description of query_builder option
@wouterj
Copy link
Member

wouterj commented Jun 20, 2016

Thanks for taking care of this issue @HeahDude! I've merged your PR and then made things a bit shorter (and removed the unclear "default loading" phase) in 94c0f45. As always, feel free to comment if you don't agree.

xabbuh added a commit that referenced this pull request Jun 20, 2016
* 2.8:
  Updating recommended email settings for monolog
  Update upload_file.rst
  fix dumper default representation
  Improve `Finder::path` code example about resulting matches
  preg_match throw an warning
  [#6599] Make description a little bit more clear
  [Process] tweak a sentence
  Fixed null description of query_builder option
xabbuh added a commit that referenced this pull request Jun 20, 2016
* 3.0:
  Updating recommended email settings for monolog
  Update upload_file.rst
  fix dumper default representation
  Improve `Finder::path` code example about resulting matches
  preg_match throw an warning
  [#6599] Make description a little bit more clear
  [Process] tweak a sentence
  Fixed null description of query_builder option
@HeahDude HeahDude deleted the fix/query_builder-null-description branch June 25, 2016 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants