-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating recommended email settings for monolog #6587
Conversation
jorgelbg
commented
May 21, 2016
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | >=2.3 |
Fixed tickets | #6467 |
'buffered' => array( | ||
'type' => 'buffer', | ||
'handler' => 'swift', | ||
'duplicated' => array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be deduplicated
here?
I'm new here, but I think should be change the buffered explanation with the new handler deduplicated (The |
Fixed the typos, and amended the commit. Thanks @javiereguiluz @xabbuh |
👍 |
👍 (by the way, I really dislike the "deduplication" word ... but that's something we cannot change) |
I agree with @Txumari here, after this code block we talk about the buffered handler a couple times. We should change it to deduplicated handler (and also change the description). |
Should we mantain some information about the |
…emoving some mentions of the buffer handler Fixing some syntax issues
I've updated the explanation and fixed the mentions of the |
unique over a given period of time (60 seconds by default). If the records are | ||
duplicates they are simply discarded. Adding this handler reduces the amount of | ||
notifications to a manageable level, specially in critical failure scenarios. | ||
The messages are then passed to the ``swift`` handler. This is the handler that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a blank line before this sentence to have it rendered as its own paragraph to improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
👍 I like it Status: Reviewed |
Thank you @jorgelbg. |
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #6587). Discussion ---------- Updating recommended email settings for monolog | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >=2.3 | Fixed tickets | #6467 Commits ------- 133d36b Updating recommended email settings for monolog