-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use symfony.com theme on Platform.sh builds #5606
Conversation
Could we run this with the |
👍 |
Let's try :) |
Deployment failed, is there any way to see why /cc @GuGuss ? |
The exact error message is:
@wouterj I'll add you as an administrator to the Platform.sh project so you can see build results directly. |
@wouterj You cannot put files in Platform.sh supports multiple applications in the same repository. The first step of the build process is to split the repository into multiple application trees, each application being defined as a folder containing a Technically, |
So things seem to work now! Thanks for the detailed information @damz. In case anyone wonders why some code blocks do have line numbers, without the customized codeblock from the sphinx-php package, line numbers are only shown when the |
Wow!!! Great work, Wouter! 🎆 |
And that looks pretty awesome. 👍 |
Looking better and better 👍 |
b5bbf7e
to
4acea02
Compare
And now, the last remaining piece is also added: Numbered code block @weaverryan this is ready to merge |
For some reason this failed on platform.sh. Are you able to see the reason @wouterj? |
Not sure why it can't check out that commit... |
@@ -1 +1 @@ | |||
Subproject commit 52f7bd2216cc22ef52494f346c5643bb2a74513f | |||
Subproject commit 1b7c4b794d75f7b0eb6749cadccc58f87e3158a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this submodule, as we download it via pip in the .platform.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't you use pip on Travis, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used submodules for travis as I didn't know we could use pip. Let's switch everything to pip :)
And everything really works now. Thanks for the help everyone! |
@@ -1,2 +1,3 @@ | |||
/_build | |||
/_exts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/_exts
can be removed now.
It was here to avoid people submitting changes to the submodule reference by mistake, but we don't have anything here anymore
Wow wow wow! This looks amazing! Seriously - this is so cool :). I'll happily merge this! |
Requires fabpot/sphinx-php#30 to be merged first.