Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symfony.com theme on Platform.sh builds #5606

Closed
wants to merge 9 commits into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 8, 2015

Requires fabpot/sphinx-php#30 to be merged first.

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

Could we run this with the CodeBlock class from the Sphinx core until the related pull request is merged?

@GuGuss
Copy link

GuGuss commented Aug 18, 2015

👍

@wouterj
Copy link
Member Author

wouterj commented Aug 18, 2015

Let's try :)

@wouterj
Copy link
Member Author

wouterj commented Aug 18, 2015

Deployment failed, is there any way to see why /cc @GuGuss ?

@GuGuss
Copy link

GuGuss commented Aug 18, 2015

The exact error message is:

Extension error:
    Could not import extension symfonycom.sphinx (exception: No module named symfonycom.sphinx)
    make: *** [html] Error 1

  E: Unknown error in the toolstack: CalledProcessError: Command 'pip install git+https://github.com/fabpot/sphinx-php.git
  make html
  ' returned non-zero exit status 2

E: Error building the project: Unable to build project, aborting deployment.

@wouterj I'll add you as an administrator to the Platform.sh project so you can see build results directly.

@damz
Copy link
Contributor

damz commented Aug 18, 2015

@wouterj You cannot put files in .platform and expect them to be available during the build process.

Platform.sh supports multiple applications in the same repository. The first step of the build process is to split the repository into multiple application trees, each application being defined as a folder containing a .platform.app.yaml, excluding any subfolder itself containing a .platform.app.yaml.

Technically, .platform/ is a global folder, it is not part of the tree of any of the applications that you have in your repository, so it will not be available during the build process of any application.

@wouterj
Copy link
Member Author

wouterj commented Aug 18, 2015

So things seem to work now! Thanks for the detailed information @damz.

In case anyone wonders why some code blocks do have line numbers, without the customized codeblock from the sphinx-php package, line numbers are only shown when the :linenums: flag is passed. Quite a few code blocks have this flag.

@xabbuh
Copy link
Member

xabbuh commented Aug 18, 2015

Wow!!! Great work, Wouter! 🎆

@damz
Copy link
Contributor

damz commented Aug 18, 2015

And that looks pretty awesome. 👍

@GuGuss
Copy link

GuGuss commented Aug 19, 2015

Looking better and better 👍

@wouterj wouterj force-pushed the symfony.com_theme branch from b5bbf7e to 4acea02 Compare August 19, 2015 20:13
@wouterj
Copy link
Member Author

wouterj commented Aug 19, 2015

And now, the last remaining piece is also added: Numbered code block

@weaverryan this is ready to merge

@xabbuh
Copy link
Member

xabbuh commented Aug 19, 2015

For some reason this failed on platform.sh. Are you able to see the reason @wouterj?

@wouterj
Copy link
Member Author

wouterj commented Aug 19, 2015

E: Error building the project: Error checking out submodule 1b7c4b794d75f7b0eb6749cadccc58f87e3158a0.

Not sure why it can't check out that commit...

@@ -1 +1 @@
Subproject commit 52f7bd2216cc22ef52494f346c5643bb2a74513f
Subproject commit 1b7c4b794d75f7b0eb6749cadccc58f87e3158a0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this submodule, as we download it via pip in the .platform.yml ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't you use pip on Travis, do we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we used submodules for travis as I didn't know we could use pip. Let's switch everything to pip :)

@wouterj
Copy link
Member Author

wouterj commented Aug 19, 2015

And everything really works now. Thanks for the help everyone!

@@ -1,2 +1,3 @@
/_build
/_exts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/_exts can be removed now.
It was here to avoid people submitting changes to the submodule reference by mistake, but we don't have anything here anymore

@weaverryan
Copy link
Member

Wow wow wow! This looks amazing! Seriously - this is so cool :).

I'll happily merge this!

@wouterj wouterj deleted the symfony.com_theme branch August 21, 2015 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants