Rewrite sentence about fingers crossed handler action level #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoek09
commented
Jun 19, 2015
snoek09
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #5370 |
Closed
| The ``critical`` level is only triggered for 5xx HTTP code errors. If this level | ||
| is reached once, the ``fingers_crossed`` handler will log everything, including | ||
| messages below the ``critical`` level. The ``handler`` setting means that the output | ||
| is then passed onto the ``buffered`` handler. | ||
|
|
There was a problem hiding this comment.
What if we go a bit further and simplify the original sentence even more? For example:
If this level is reached once, the ``fingers_crossed`` handler will log all messages
regardless of their level.
|
I think this is much better now. Thank you for your pull request @snoek09! |
|
SO much clearer now (I think I probably wrote the original). Thanks Henry! |
weaverryan
added a commit
that referenced
this pull request
Jun 29, 2015
…el (snoek09) This PR was merged into the 2.3 branch. Discussion ---------- Rewrite sentence about fingers crossed handler action level | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #5370 Commits ------- ebebe1d 5370 simplify original sentence 2982000 5370 rewrite sentence about fingers crossed handler action level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.