Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Security into Authentication & Authorization #5367

Merged
merged 2 commits into from
Jul 7, 2015

Conversation

linaori
Copy link
Contributor

@linaori linaori commented Jun 8, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets ~

I have divided the security part into Authentication and Authorization. This is done visually only, structure wise they are still together. There's still an issue regarding the sorting, it will be a lot clearer if the lists are re-sorted but I will do this in another PR once this is done.

I think I've update all the index pages that mention this, but if I missed something, I can add that.

@stof
Copy link
Member

stof commented Jun 8, 2015

you need to update the map file so that pages appear in the same order in the map than here. Otherwise the prev and next links will be wrong

@linaori
Copy link
Contributor Author

linaori commented Jun 8, 2015

@stof which one do you mean? I've updated 1 map file.

@@ -1,6 +1,8 @@
Security
========

* Authentication
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use subsections:

Authentication
--------------

...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might indeed be a nice thing, I'll update this.

multiple_user_providers


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need two blank lines here

@linaori linaori force-pushed the feature/security-split branch from 1d04f6d to 825f447 Compare June 15, 2015 11:16
@xabbuh
Copy link
Member

xabbuh commented Jun 16, 2015

👍

@@ -143,27 +143,30 @@
* :doc:`/cookbook/routing/redirect_trailing_slash`
* :doc:`/cookbook/routing/extra_information`

* :doc:`/cookbook/security/index`
* :doc:`Authentication </cookbook/security/index>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: Security Authentication

and below Security Authorization

so that when people search for "security", then find these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our conversation on IRC:

Security Authentication (Identifying/Logging in the User)

Security Authorization (Denying Access)

@weaverryan weaverryan merged commit 825f447 into symfony:2.3 Jul 7, 2015
weaverryan added a commit that referenced this pull request Jul 7, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Split Security into Authentication & Authorization

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | ~

I have divided the security part into Authentication and Authorization. This is done visually only, structure wise they are still together. There's still an issue regarding the sorting, it will be a lot clearer if the lists are re-sorted but I will do this in another PR once this is done.

I think I've update all the index pages that mention this, but if I missed something, I can add that.

Commits
-------

825f447 Changed Authorization and Authentication to use subsections
2e2068a Split Security into Authentication & Authorization
weaverryan added a commit that referenced this pull request Jul 7, 2015
@weaverryan
Copy link
Member

Thanks @iltar - nice idea. I updated the titles a bit at sha: eb1ee92.

Cheers!

weaverryan added a commit that referenced this pull request Jul 7, 2015
* 2.3:
  Reordered the configuration blocks of the first example
  Fixed some errors and made some simplifications
  Added the "payload" option back (was removed by mistake)
  Fixed the order of the examples
  Simplified the first example and added more examples
  [Validator] Updated documentation of URL validator
  Fixed typos
  Removed duplication and moved a caution message
  [Console] Added a cookbook entry on invoking other commands
  [#5367] Making the titles more searchable
  fix #5487
  Changed Authorization and Authentication to use subsections
  Split Security into Authentication & Authorization
weaverryan added a commit that referenced this pull request Jul 7, 2015
* 2.6:
  Reordered the configuration blocks of the first example
  Fixed some errors and made some simplifications
  Added the "payload" option back (was removed by mistake)
  Fixed the order of the examples
  Simplified the first example and added more examples
  [Validator] Updated documentation of URL validator
  Fixed typos
  Removed duplication and moved a caution message
  [Console] Added a cookbook entry on invoking other commands
  [#5367] Making the titles more searchable
  fix #5487
  Changed Authorization and Authentication to use subsections
  Split Security into Authentication & Authorization
weaverryan added a commit that referenced this pull request Jul 7, 2015
* 2.7:
  [#5426] Porting the checkDNS option to 2.7 only
  Reordered the configuration blocks of the first example
  Fixed some errors and made some simplifications
  Added the "payload" option back (was removed by mistake)
  Fixed the order of the examples
  Simplified the first example and added more examples
  [Validator] Updated documentation of URL validator
  Fixed typos
  Removed duplication and moved a caution message
  [Console] Added a cookbook entry on invoking other commands
  [#5367] Making the titles more searchable
  fix #5487
  [FrameworkBundle] Update serializer configuration reference
  Changed Authorization and Authentication to use subsections
  Split Security into Authentication & Authorization
weaverryan added a commit that referenced this pull request Jul 7, 2015
* 2.7:
  [#5426] Porting the checkDNS option to 2.7 only
  Reordered the configuration blocks of the first example
  Fixed some errors and made some simplifications
  Added the "payload" option back (was removed by mistake)
  Fixed the order of the examples
  Simplified the first example and added more examples
  [Validator] Updated documentation of URL validator
  Fixed typos
  Removed duplication and moved a caution message
  [Console] Added a cookbook entry on invoking other commands
  [#5367] Making the titles more searchable
  fix #5487
  [FrameworkBundle] Update serializer configuration reference
  Changed Authorization and Authentication to use subsections
  Split Security into Authentication & Authorization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants