Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doctrine] Documentation about subscribers is outdated #15234

Closed
Nek- opened this issue Apr 13, 2021 · 1 comment
Closed

[doctrine] Documentation about subscribers is outdated #15234

Nek- opened this issue Apr 13, 2021 · 1 comment
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.

Comments

@Nek-
Copy link
Contributor

Nek- commented Apr 13, 2021

The documentation about doctrine state things about subscribers but it's not up to date because the situation changed in the doctrine bundle.

Before:

class MyAwesomeSubscriber implements EventSubscriber
{
    // ...
}
# config/services.yaml
services:
    # ...

    App\Doctrine\MyAwesomeSubscriber:
        tags:
            - { name: 'doctrine.event_subscriber' }

After:

class MyAwesomeSubscriber implements EventSubscriberInterface
{
    // ...
}

(and that's all)

Changed since Doctrine Bundle 2.1.0.

@javiereguiluz
Copy link
Member

Maxime, thanks for reporting this issue.

For reference: DoctrineBundle 2.1.0 was released in May 2020: https://github.com/doctrine/DoctrineBundle/releases/tag/2.1.0

So, maybe we could assume that people are already using it ... but even if we update code, we should probably add a note for those using an earlier version of the bundle.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doctrine hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

4 participants