-
-
Notifications
You must be signed in to change notification settings - Fork 105
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d129c01
commit cddcf9b
Showing
4 changed files
with
12 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,8 +17,8 @@ | |
/** | ||
* WindowsPipes implementation uses temporary files as handles. | ||
* | ||
* @see https://bugs.php.net/bug.php?id=51800 | ||
* @see https://bugs.php.net/bug.php?id=65650 | ||
* @see https://bugs.php.net/51800 | ||
* @see https://bugs.php.net/65650 | ||
* | ||
* @author Romain Neutron <[email protected]> | ||
* | ||
|
@@ -43,7 +43,7 @@ public function __construct($input, $haveReadSupport) | |
// Fix for PHP bug #51800: reading from STDOUT pipe hangs forever on Windows if the output is too big. | ||
// Workaround for this problem is to use temporary files instead of pipes on Windows platform. | ||
// | ||
// @see https://bugs.php.net/bug.php?id=51800 | ||
// @see https://bugs.php.net/51800 | ||
$pipes = [ | ||
Process::STDOUT => Process::OUT, | ||
Process::STDERR => Process::ERR, | ||
|
@@ -105,8 +105,8 @@ public function getDescriptors() | |
]; | ||
} | ||
|
||
// We're not using pipe on Windows platform as it hangs (https://bugs.php.net/bug.php?id=51800) | ||
// We're not using file handles as it can produce corrupted output https://bugs.php.net/bug.php?id=65650 | ||
// We're not using pipe on Windows platform as it hangs (https://bugs.php.net/51800) | ||
// We're not using file handles as it can produce corrupted output https://bugs.php.net/65650 | ||
// So we redirect output within the commandline and pass the nul device to the process | ||
return [ | ||
['pipe', 'r'], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters