Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:registration] cleanup maker and template #914

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[make:registration] cleanup maker and template #914

merged 1 commit into from
Jun 30, 2021

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Jun 30, 2021 •
edited
Loading

  • Implements a new use statement sorter for templates
  • use class properties instead of abusing command arguments

@jrushlow jrushlow force-pushed the feature/use-sorter branch 2 times, most recently from 81df3f9 to 0a0c4d8 Compare June 30, 2021 14:35
@jrushlow jrushlow changed the title [WIP] sorter [make:registration] cleanup maker and template Jun 30, 2021
@jrushlow jrushlow marked this pull request as ready for review June 30, 2021 15:09
weaverryan
weaverryan reviewed Jun 30, 2021
View reviewed changes
src/Generator.php Outdated Show resolved Hide resolved
src/Util/TemplateComponentGenerator.php
/**
* @author Jesse Rushlow <[email protected]>
*
* @internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we've used this a bunch and finalized it, we should consider removing the @internal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed - I'm thinking that once we roll out the other pieces to the "new template generator", make all of those components available for use in userland code.

@jrushlow jrushlow force-pushed the feature/use-sorter branch from 0a0c4d8 to 0fca705 Compare June 30, 2021 19:31
@weaverryan weaverryan force-pushed the feature/use-sorter branch from b701abe to 771444d Compare June 30, 2021 19:44
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 7b5c342 into symfony:main Jun 30, 2021
@jrushlow jrushlow deleted the feature/use-sorter branch May 3, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrushlow @weaverryan