Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use openapi-client for calls to statistics service #1757

Closed
cryptoBeliever opened this issue Nov 1, 2021 · 1 comment
Closed

Use openapi-client for calls to statistics service #1757

cryptoBeliever opened this issue Nov 1, 2021 · 1 comment
Assignees
@bassemmagdy

Comments

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Nov 1, 2021 •
edited
Loading

In NodeService.js we calling statistics service for node list:

const data = await requestNodes(networkType, nodeSearchCriteria);

It should be replaced top openapi-client (symbol-statistics-service-typescript-fetch-client).

Example in bootstrap: https://github.com/symbol/symbol-bootstrap/blob/c846846245e02d8886fac5985374da0a15b05a83/src/service/RemoteNodeService.ts#L136

If same is needed in mobile (symbol/mobile-wallet#246) please open seperate issue in mobile wallet repository (https://github.com/symbol/mobile-wallet/issues)
@cryptoBeliever cryptoBeliever mentioned this issue Nov 1, 2021
Merged
@bassemmagdy
Copy link
Contributor

duplicate of #1776

@cryptoBeliever cryptoBeliever marked this as a duplicate of #1776 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassemmagdy @cryptoBeliever