Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosaic creation issue. Mosaic supply is unclear #1561

Closed
OlegMakarenko opened this issue Jun 25, 2021 · 5 comments · Fixed by #1651
Closed

Mosaic creation issue. Mosaic supply is unclear #1561

OlegMakarenko opened this issue Jun 25, 2021 · 5 comments · Fixed by #1651
Assignees
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action

Comments

@OlegMakarenko
Copy link
Contributor

OlegMakarenko commented Jun 25, 2021

Problem:
At this moment, the wallet use absolute amount for mosaic supply change, but there is no info about it.
It might be unclear to the user what amount will be received.

Solution:
Add a dynamic text field to present relative amount which will be received

Supply (absolute amount): 120 000
Divisibility: 2
Result amount: 1 200.00

image

@cryptoBeliever cryptoBeliever added the P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action label Jul 12, 2021
@yilmazbahadir yilmazbahadir self-assigned this Aug 17, 2021
@yilmazbahadir
Copy link
Contributor

This is how it'll look like. @cryptoBeliever @OlegMakarenko

Not 100% sure about the labels but using Supply Units for the absolute and Supply Amount for the relative felt right.

Will raise the PR soon if that's alright. (Open to any other suggestions though.)

image

@cryptoBeliever
Copy link
Contributor

Considering also view to change supply:

image

I would:

  • change Supply Amount to Supply
  • change Supply Change Amount to Supply Change Units

@yilmazbahadir
Copy link
Contributor

Yeah, that could work (if we refer Supply as relative by default)

Can you also check if the Current Supply and New Supply fields are formatted correctly? In the image you shared should be showing 4 decimal places for relative (the divisibility is 4)

@cryptoBeliever
Copy link
Contributor

@yilmazbahadir you are right. On supply modification view new and current relative supply is presented always with 3 places after decimal point. Places after decimal point should be equal to divisibility

Example mosaic with divisibility 6

image

@cryptoBeliever
Copy link
Contributor

Fixed in dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Issue Feature or UI issue preventing an action, Incomplete process or crashing during action
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants