-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
de-duplicate fuse mounting/unmounting code #2199
de-duplicate fuse mounting/unmounting code #2199
Conversation
a550c50
to
21f2008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking shape nicely. I've left some comments. My chief concern is that extra options must not be allowed to potentially override things that are set from specific attributes of ImageMount.
… CE's squashfs code
…ashfs/fuse; add ctx args as needed
b67f8e8
to
1781b79
Compare
5666227
to
a54a580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is LGTM - but I think I missed something r.e. uid / gid handling which should probably at this point mean that they are handled as attributes?
831a664
to
4f53e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - noted some typos in comments
aecd206
to
8ced169
Compare
Description of the Pull Request (PR):
Transition as much FUSE-related code as is currently feasible to using internal/pkg/util/fs/fuse package.
This PR addresses FUSE-related code in the following source files:
(These two are related to use of the
--sif-fuse
flag in native mode.)This PR does not address FUSE-related code in the following source files (see #2201):
(These three are related to passing FUSE mounts by file-descriptor from host to container.)
This fixes or addresses the following GitHub issues: