WIP: oci: buildkit TMPDIR fallback #3407
Draft
+44
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Work in progress....
Use a TMPDIR location if the ~/.singularity/singularity-buildkitd location is on a filesystem that won't work for buildkit (as determined by overlay.CheckUpper which is used elsewhere also).
This should fix #3382 but the current PR is not suitable to merge. Exit handling is pretty nasty due to the flow in which singularity-builtkitd is started, and waited for, by singularity as a buildkit client. We don't really have a nice termination route prior to the GRPC server being started... but the TMPDIR and config needs to be setup before that.
Needs re-work of how we launch singularity-buildkitd and catch errors client-side that are earlier / not visible across the client->server socket.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).